Please merge topic/feature/logging-filter-list

Description

Please merge topic/feature/logging-filter-list.

It implements a function that allows you to get the current list of filters for a specified logging stream (which so far was impossible). It also fixes a few small issues with the base logging script and implements the so far missing enable_stream function.

Please attribute this change to Corelight.

Environment

None

Activity

Show:
Jon Siwek
January 18, 2018, 6:12 AM

What's the reason for the following type of pattern?

I also noticed that in at least one other place, and probably not a big deal for this particular code, though I'm wondering if you had encountered actual problems with the original code? I had thought delete statements internally have to do a lookup anyway and turn into a no-op if the index does not exist, so the lookup conditions in the example above would be superfluous.

If there was a real problem with deleting from a non-existent index, I think that would need to be fixed, else I'll just remove the extra existence checks during the merge.

Jon Siwek
January 18, 2018, 9:22 AM

Merged, thanks. (Seems there were transient JIRA issues, so Johanna responded to my previous question by email, indicating the extra checks shouldn't really be needed and to remove them).

Merged

Assignee

Jon Siwek

Reporter

Johanna Amann

Labels

None

External issue ID

None

Components

Fix versions

Affects versions

Priority

Normal