Please merge topic/johanna/ssl_signature_details

Description

Please merge topic/johanna/ssl_signature_details.

This branch adds more details to the ssl_server_signature event and parses the (so far unparsed) datastructure of this event.

Environment

None

Activity

Show:
Robin Sommer
February 6, 2018, 10:21 AM

One question: why not make the fields of SignatureAndHashAlgorithm optional, instead of setting to 256 if not available?

Johanna Amann
February 7, 2018, 4:30 AM

I think that I did that because SignatureAndHashAlgorithm already existed and is used and is primarily used in contexts where it is not optional.

That being said - I can see both ways and I am happy to change it if you think it would be better as an optional.

Robin Sommer
February 7, 2018, 6:56 AM

went ahead and merged as is. I think I'd still prefer the optional, but not a big deal.

Merged

Assignee

Robin Sommer

Reporter

Johanna Amann

Labels

None

External issue ID

None

Components

Fix versions

Affects versions

Priority

Normal