merge topic/vern/pattern-ops

Description

This branch supports & and | operators for general pattern operands.

Environment

None

Activity

Show:
Vern Paxson
June 23, 2018, 8:44 AM

Right, it's not limited.

What do you mean by add a leak-check? What would be the mechanism for seeing whether there's a leak?

Johanna Amann
June 23, 2018, 8:52 AM

Turns out that we have documentation for this

https://www.bro.org/development/howtos/leaks.html

The tests in core/leaks employ this method to check for memory leaks (if Bro is compiled with the right flags as shown in that article). Having a test like that for patterns seems like it might make sense

Johanna

Vern Paxson
June 27, 2018, 3:47 AM

Thanks for the pointer (and follow-on help; shout-out to Jon too!). topic/vern/pattern-leaks now fixes those leaks, so we should be good-to-go. Will put in a merge request for it now.

Vern Paxson
June 27, 2018, 3:59 AM

(just pushed a comit to topic/vern/pattern-leaks that fixes a bug in this branch)

Vern Paxson
June 27, 2018, 4:55 AM

(Oh and a heads-up for those following from home: the info on the web page mentioned above doesn't come close to working under MacOS. Instead, use "leaks".)

Merged

Assignee

Jon Siwek

Reporter

Vern Paxson

Labels

None

External issue ID

None

Components

Fix versions

Priority

Normal