merge topic/vern/perf-history

Description

This branch adds support for: (1) 'W'/'w' history indicators for zero-window closures, (2) repeated indicators for W/T/C when they occur 10, 100, 1000, ... times for a single connection, (3) events that are generated upon such repetitions.

Environment

None

Activity

Show:
Jon Siwek
August 2, 2018, 7:48 AM

Thanks, I mostly merged this except for the change here:

https://github.com/bro/bro/commit/73349362a3e5cec0625738b711bf7aca9c6d8ab6#diff-36fc3997b09a52369ce83e8976e8728eL622

Would that then unconditionally track window changes regardless of packet ordering?

With that change, there's unit test baseline differences showing new window_recision weirds:

  • core.tunnels.teredo_bubble_with_payload

  • plugins.writer

  • scripts.base.protocols.modbus.exception_handling

  • the "external/bro-testing" test suite also shows a mild difference in number of window_recision weirds

Can you elaborate on that change or else confirm that the differences in the tests are valid?

Jon Siwek
August 2, 2018, 7:51 AM

To clarify, I'm referring to how these statements got moved around:

Assignee

Vern Paxson

Reporter

Vern Paxson

Labels

None

External issue ID

None

Components

Priority

Normal