Confusing warning in reporter.log when reading ports into config framework

Description

If a config framework runtime option has type "port", and if a user tries to modify
the value at runtime by reading a port value from a file, then it works correctly,
but there is an erroneous and confusing warning message in reporter.log.

For example, given:
module Mytest;
export {
option myport: port = 123/tcp;
}

Then, when a user has a config file that looks like this:
Mytest::myport 57/udp

The new value is correctly applied to the "myport" runtime option,
but there is a warning in reporter.log that looks like this:

#fields ts level message location
#types time enum string string
0.000000 Reporter::WARNING /Users/test/bro/config.dat/Input::READER_CONFIG: Number '57/udp' contained non-numeric trailing characters. Ignored trailing characters '/udp' (empty)

Environment

None

Activity

Show:
Johanna Amann
August 11, 2018, 7:29 AM

This is fixed in topic/johanna/config-framework-fixes

The branch also includes 2 more small changes:

Reading bools is now a bit more permissive and also accepts 0 and 1 in addition to T and F.

Options are now automatically redef-able (this was discussed quite a while ago and I more or less forgot it till now).

Merged

Assignee

Jon Siwek

Reporter

Daniel Thayer

Labels

None

External issue ID

None

Components

Fix versions

Priority

Low