Add payload to ICMP analyzer

Description

This is a patch from Julien Sentier on the mailing list that makes ICMP payloads available at the scripting layer. Is there a reason this isn't already available? I would have committed it to fastpath except I don't know if it's not already doing this due to the potential overhead of creating a lot of strings in ICMP floods. At the very least, I suppose it could be optional (which the patch doesn't currently do).

Environment

None

Activity

Show:
Jon Siwek
July 12, 2012, 2:41 PM

Replying to [seth|comment:11]:
> Did this happen? I didn't track the ICMP changes closely.

No icmp_sent events still don't include a payload parameter.

Seth Hall
July 12, 2012, 3:54 PM

Bumping this then. It's too big of a change to include now.

Jon Siwek
March 17, 2015, 5:24 PM

I'll just add a new icmp_sent_payload event for this to address the overhead concern.

Jon Siwek
March 18, 2015, 9:19 PM

topic/jsiwek/bit-342

Robin Sommer
March 23, 2015, 7:51 PM

.

Merged

Assignee

Robin Sommer

Reporter

Seth Hall

Labels

None

External issue ID

342

Components

Fix versions

Affects versions

Priority

Normal
Configure