Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

SMB file not used?

Description

I noticed that src/analyzer/protocol/smb/smb1_com_open_andx.bif doesn't seem to be used, unless I'm missing something. I noticed it because the "see also" entries in the documentation referring to the events in there don't resolve.

Environment

None

Activity

Show:

Seth Hall November 2, 2016 at 2:08 PM

The changes for this ticket are in topic/seth/smb-auth-fixes. It has a lot more than auth fixes (including the changes requested in this ticket), but I would appreciate some general review of the code. It is running on one large network with lots of SMB and generally seems to be behaving itself well.

Seth Hall November 1, 2016 at 8:37 PM

I committed some changes into the branch I've been doing SMB work in topic/seth/smb-auth-fixes (it's an overloaded branch).

Changes are being tested now and I'll mark this as a merge request for Johanna since she said she'd do a quick skim over my changes and merge it.

Seth Hall October 27, 2016 at 4:20 PM

I can remove it. I have some other smb changes getting ready right now anyway.

Robin Sommer October 27, 2016 at 3:10 PM

Anyone on this?

Robin Sommer October 9, 2016 at 3:39 PM

If it's deliberately not used I think we should either remove the corresponding *.bif files for now (we can always pull them back out of git later), or rename them into something conveying so, like "smb1_com_open_andx.bif.NOT-USED".

Merged

Details

Assignee

Reporter

Components

Fix versions

Priority

Created October 6, 2016 at 9:06 PM
Updated November 2, 2016 at 5:56 PM
Resolved November 2, 2016 at 5:56 PM